[webkit-reviews] review granted: [Bug 12463] WebArchiver - attempt to insert nil exception when archive empty iframe : [Attachment 12773] revised patch (no tabs this time)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Jan 29 22:14:28 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12463: WebArchiver - attempt to insert nil exception when archive empty
iframe
http://bugs.webkit.org/show_bug.cgi?id=12463

Attachment 12773: revised patch (no tabs this time)
http://bugs.webkit.org/attachment.cgi?id=12773&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, but don't we need the same change in this method?

+ _archiveWithMarkupString:fromFrame:nodes:

I'd like to see this test added to the regression tests somehow. I think that
can be done by enhancing DumpRenderTree.



More information about the webkit-reviews mailing list