[webkit-reviews] review denied: [Bug 12462] Need -[WebView setAllowsUndo:] API : [Attachment 12766] patch

[bugzilla-request-daemon at macosforge.org]

Mark Rowe (bdash) <bdash at webkit.org> has denied Mark Rowe (bdash)
<bdash at webkit.org>'s request for review:
Bug 12462: Need -[WebView setAllowsUndo:] API
http://bugs.webkit.org/show_bug.cgi?id=12462

Attachment 12766: patch
http://bugs.webkit.org/attachment.cgi?id=12766&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
A few comments:
1) you should include the ChangeLog entry as part of the patch rather than as a
separate file.
2) +	    if ([decoder containsValueForKey: @"AllowsUndo"])  has extra
whitespace after the colon.
3) 
+    if (! _private->allowsUndo) {
+	 return nil;
+    }

has unneeded braces.

If you could address those two minor issues, resubmit your patch and mark it r?
I will take another look and land it.