[webkit-reviews] review denied: [Bug 12422] [S60] Disabling Java/ECMA script on www.viamichelin.com crashes Browser : [Attachment 12692] Fix the crash of disable JavaScript settings while the page is open.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Jan 28 20:01:09 PST 2007


Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 12422: [S60] Disabling Java/ECMA script on www.viamichelin.com crashes
Browser
http://bugs.webkit.org/show_bug.cgi?id=12422

Attachment 12692: Fix the crash of disable JavaScript settings while the page
is open.
http://bugs.webkit.org/attachment.cgi?id=12692&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
fix looks great but you dont have to declare the proxy variable unless you
really use it.
so either 
if (!KJSProxy::proxy(window->m_part))
   {
   return;
   }
or

KJSProxy *proxy = KJSProxy::proxy(window->m_part);
if (!proxy)
   {
   return;
   }
ScriptInterpreter *interpreter = static_cast<ScriptInterpreter
*>(proxy->interpreter());



More information about the webkit-reviews mailing list