[webkit-reviews] review granted: [Bug 12340] XPathEvaluator behavior does not match Firefox - name() and attribute nodes : [Attachment 12723] proposed fix

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12340: XPathEvaluator behavior does not match Firefox - name() and
attribute nodes
http://bugs.webkit.org/show_bug.cgi?id=12340

Attachment 12723: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12723&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Should that be prefix.isEmpty() instead of prefix.isNull()? Is it possible to
construct a test that would behave differently depending on which you used?

In general, I recommend taking advantage of the null value as distinct from
empty only when it's necessary, so if either would work the same I'd prefer
isEmpty.