[webkit-reviews] review requested: [Bug 12350] Add calcMode support to SVG Animation : [Attachment 12677] final patch, with test cases

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 12350: Add calcMode support to SVG Animation
http://bugs.webkit.org/show_bug.cgi?id=12350

Attachment 12677: final patch, with test cases
http://bugs.webkit.org/attachment.cgi?id=12677&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I'm not sure if anyone in particular is particularly qualified to review this. 
WildFox originally wrote this code.  This is a total re-write, so mostly I
expect folks to sanity check the individual *Distance classes, and give a
rubber stamp to the "oh, that architecture more-or-less looks sane".  I'm happy
to talk about any of these changes over IRC.  The resulting state of animation
is certainly better than TOT.  calcMode, keyTimes work (which they didn't
before).

Some thoughts on what remains broken:
keySplines is a few lines of code away from working (code to find a point on a
line given an x value).  freeze and repeat accumulations do not work (but I'm
not sure they did before either).  The underlying animVal/baseVal system is
still broken.  <animate> can't really be wired in correctly until a system for
handling animated mapped attributes, and animated styles is devised.