[webkit-reviews] review requested: [Bug 12385] Assertion failure when loading subresources from "data:" frames : [Attachment 12670] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Jan 25 12:34:28 PST 2007


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12385: Assertion failure when loading subresources from "data:" frames
http://bugs.webkit.org/show_bug.cgi?id=12385

Attachment 12670: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12670&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
So, it looks like such URLs are treated as invalid by Firefox.

Please note that the code for invalid base URLs was only executed for empty
ones, because non-empty invalid base URLs were dealt with at the beginning of
KURL::init().

There are still some issues with handling "javascript:" URLs (see comments in
the test case), but those are outside KURL, and have bugs of their own filed.



More information about the webkit-reviews mailing list