[webkit-reviews] review granted: [Bug 12394] Cleanup RenderBox : [Attachment 12644] patch

[bugzilla-request-daemon at macosforge.org]

mitz at webkit.org has granted mitz at webkit.org's request for review:
Bug 12394: Cleanup RenderBox
http://bugs.webkit.org/show_bug.cgi?id=12394

Attachment 12644: patch
http://bugs.webkit.org/attachment.cgi?id=12644&action=edit

------- Additional Comments from mitz at webkit.org
-    if (isFloating() || (isCompact() && isInline()) || 
+    if (isFloating() || (isCompact() && isInline()) ||
	 (isInlineBlockOrInlineTable() && !isHTMLMarquee()))

In other places in this patch you moved the operator after the line break. Same
here:

-	     m_height = max(m_height, visHeight - 
-			     (margins + parent()->marginTop() +
parent()->marginBottom() + 
+	     m_height = max(m_height, visHeight -
+			     (margins + parent()->marginTop() +
parent()->marginBottom() +

and here:

+	 for (; !cb->isRenderView() && !cb->isBody() && !cb->isTableCell() &&
!cb->isPositioned() &&
		 cb->style()->height().isAuto(); cb = cb->containingBlock());

r=me