[webkit-reviews] review requested: [Bug 12375] REGRESSION(r19038): fast/dom/title-text-property-2.html failing : [Attachment 12641] Patch v2

[bugzilla-request-daemon at macosforge.org]

Mark Rowe (bdash) <bdash at webkit.org> has asked	for review:
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing
http://bugs.webkit.org/show_bug.cgi?id=12375

Attachment 12641: Patch v2
http://bugs.webkit.org/attachment.cgi?id=12641&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
This includes a layout test for the handling of multiple SVG title elements. 
document.title is read-only in the SVG DOM which means there are fewer cases to
test.  I cannot see a specification for the expected behaviour when multiple
title elements are present and the first (i.e., the one currently in use) is
removed.

The biggest change in this patch is to removeTitle: we update the document
title based on the first title element in the head element, if one exists. 
This matches the current Web App 1.0 specification, but differs from both Opera
and Firefox.  Opera will update the document title based on the first title
element anywhere in the document, while Firefox continues using a title set via
document.title even when the element it applied to was removed.

I believe I've addressed all the other review comments made by Darin + Mitz.