[webkit-reviews] review denied: [Bug 12375] REGRESSION(r19038): fast/dom/title-text-property-2.html failing : [Attachment 12619] Patch

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing
http://bugs.webkit.org/show_bug.cgi?id=12375

Attachment 12619: Patch
http://bugs.webkit.org/attachment.cgi?id=12619&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Mitz's comments seem to justify a review-. Here are a few additional ones:

+	     RefPtr<NodeList> headElements = getElementsByTagName("head");
+	     if (Node *headElement = headElements->item(0)) {

I suggest adding a head() function alongside the body() function to encapsulate
this.

Now that HTML and non-HTML are going to work differently as far as titles are
concerned, we might need some SVG or XML test cases.

-	 m_titleElement = 0;
+	 if (!m_titleElement && isHTMLDocument()) {

In the non-HTML-document case, maybe we should be setting m_titleElement to 0
as before?