[webkit-reviews] review granted: [Bug 11197] REGRESSION: Specifying a counter for a CODE tag's content style property on before or after causes a crash. : [Attachment 12590] much larger patch, passes layout tests, I think we should land this one

[bugzilla-request-daemon at macosforge.org]

mitz at webkit.org has granted mitz at webkit.org's request for review:
Bug 11197: REGRESSION: Specifying a counter for a CODE tag's content style
property on before or after causes a crash.
http://bugs.webkit.org/show_bug.cgi?id=11197

Attachment 12590: much larger patch, passes layout tests, I think we should
land this one
http://bugs.webkit.org/attachment.cgi?id=12590&action=edit

------- Additional Comments from mitz at webkit.org
\ No newline at end of file

Please add a newline.

+		 if (style()->collapseWhiteSpace() && next && !next->isBR() &&
next->isText() && static_cast<RenderText*>(next)->textLength() > 0) {

The > 0 is unnecessary.

+		     if (nextText->textLength() != 0) {

Should be 'if (nextText->textLength())'.

+++ WebKitTools/Scripts/run-webkit-tests	(working copy)

Doesn't belong in this patch.

r=me w/o the run-webkit-tests changes.