[webkit-reviews] review granted: [Bug 10773] Memory usage grows when reloading google.com/ig : [Attachment 12568] clean way w/ very minor style changes

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Jan 20 08:14:39 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10773: Memory usage grows when reloading google.com/ig
http://bugs.webkit.org/show_bug.cgi?id=10773

Attachment 12568: clean way w/ very minor style changes
http://bugs.webkit.org/attachment.cgi?id=12568&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    //we need to mark any DOM wrappers associated with this document

Normally we put spaces after the "//" for comments. Also, I'm not sure this
comment is good. It just repeats what the function name says. If the issue is
clarifying that these are "wrappers" then I think the ScriptInterpreter
function should be named markDOMWrappersForDocument. And lets omit the comment.


	 NodeMap::iterator nodeEnd = nodeDict->end();
+	 
	 for (NodeMap::iterator nodeIt = nodeDict->begin(); nodeIt != nodeEnd;
++nodeIt) {

I don't think that adding this blank line improves paragraphing/formatting.

Is there any way to test this in a regression test?

r=me



More information about the webkit-reviews mailing list