[webkit-reviews] review denied: [Bug 12334] Respect <text> boundaries for svg text selecting : [Attachment 12555] First attempt

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12334: Respect <text> boundaries for svg text selecting
http://bugs.webkit.org/show_bug.cgi?id=12334

Attachment 12555: First attempt
http://bugs.webkit.org/attachment.cgi?id=12555&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This is wrong:
strncmp(r->renderName(), "RenderSVGInlineText", 19) == 0 ||
strncmp(r->renderName(), "RenderSVGText", 13) == 0
we should add a virtual method isSVGTextObject() (or similar) to RenderObject
instead (if RenderSVGInlineTExt is a subclass of RenderSVGText it coudl easily
be named isSVGText())

maybe there is an easier more general way to do this?  It seems a little
awkward to hack this into the base code.