[webkit-reviews] review denied: [Bug 12293] [S60] Saved Pages: CSS
reference file not saved with page : [Attachment 12505] Save
the import .css to when we generate Page data.
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Jan 18 18:30:05 PST 2007
Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 12293: [S60] Saved Pages: CSS reference file not saved with page
http://bugs.webkit.org/show_bug.cgi?id=12293
Attachment 12505: Save the import .css to when we generate Page data.
http://bugs.webkit.org/attachment.cgi?id=12505&action=edit
------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
1,this fix fails to address the case where the imported stylesheet has an
@import in it.
2,if the css is 404, then this function tries to load it again (not sure if
that's the correct behaviour) but since the load is async, it will not be able
to save the result of the load.
2, please fix the input path in the .mmp instead of doing this #include
"../khtml/css/css_ruleimpl.h"
More information about the webkit-reviews
mailing list