[webkit-reviews] review granted: [Bug 11271] REGRESSION (r12358): Text in display: table unselectable : [Attachment 12540] Patch

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11271: REGRESSION (r12358): Text in display: table unselectable
http://bugs.webkit.org/show_bug.cgi?id=11271

Attachment 12540: Patch
http://bugs.webkit.org/attachment.cgi?id=12540&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. The way Hyatt had me fix something like this in another similar
case was to ask the renderer "isText() && !isBR()" instead of doing the
checking on the DOM tree side.

I think we should have a RenderObject call that returns style for other
renderers and 0 for text renderers that are not <br> elements. Or a boolean
check on RenderObject like isRealText() which is isText() && !isBR().

r=me