[webkit-reviews] review granted: [Bug 12305] REGRESSION: Images do not load in video sections on CNN.com homepage : [Attachment 12530] Patch v2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Jan 18 07:44:40 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12305: REGRESSION: Images do not load in video sections on CNN.com homepage
http://bugs.webkit.org/show_bug.cgi?id=12305

Attachment 12530: Patch v2
http://bugs.webkit.org/attachment.cgi?id=12530&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I know this is not in our style guide, but I personally like to format
continued expressions like this:

    return attr->name() == srcAttr
	|| attr->name() == lowsrcAttr
	|| (attr->name() == usemapAttr && attr->value().domString()[0] != '#');


Somehow it just looks more "orderly" to me.



More information about the webkit-reviews mailing list