[webkit-reviews] review requested: [Bug 6218] CSS1: WebTextRenderer caches and re-uses fallback renderers that are based on family lists : [Attachment 12531] Implement trees of fallback glyph pages

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Jan 18 06:39:21 PST 2007


mitz at webkit.org has asked  for review:
Bug 6218: CSS1: WebTextRenderer caches and re-uses fallback renderers that are
based on family lists
http://bugs.webkit.org/show_bug.cgi?id=6218

Attachment 12531: Implement trees of fallback glyph pages
http://bugs.webkit.org/attachment.cgi?id=12531&action=edit

------- Additional Comments from mitz at webkit.org
Abandoned the node-collapsing idea, instead using another technique to share
the page in the scenario described in comment #16. Collapsing nodes turned out
to be complicated because once you do it a node's level in the tree no longer
corresponds with an index into a FontFallbackList, and my solution for this was
kind of messy. It also required special-casing "system fallback".

Replaced the #include with forward declarations. There are no new files in this
patch, only moved (renamed) files, therefore I did not change the years in
copyright lines.



More information about the webkit-reviews mailing list