[webkit-reviews] review granted: [Bug 12029] Implement SVGElementInstance : [Attachment 12528] Updated patch

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12029: Implement SVGElementInstance
http://bugs.webkit.org/show_bug.cgi?id=12029

Attachment 12528: Updated patch
http://bugs.webkit.org/attachment.cgi?id=12528&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Really this is fine as is.  I think there are some design changes we still need
to make.  Most notably using the real shadowNode support which is already built
into webcore.

Also, I'm still not sure it's necessary to have a whole double-layer of
SVGElementInstance nodes, but we'll talk about that more in the next round of
patches.

You were going to add at least a couple more tests, some of which we talked
about over IRC.  Go ahead and land your improved patch with those test cases
when you find the time.  g'luck with your studies. :)