[webkit-reviews] review granted: [Bug 12301] Fix the Qt build after submit 18904 : [Attachment 12507] See description of the bug.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Jan 17 09:30:52 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12301: Fix the Qt build after submit 18904
http://bugs.webkit.org/show_bug.cgi?id=12301

Attachment 12507: See description of the bug.
http://bugs.webkit.org/attachment.cgi?id=12507&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Note, our policy is that build fixes don't necessarily need review. But I guess
this goes way beyond a build fix.

+#include "math.h"

Should be <math.h>.

 #include "IntRect.h"
 #include "MimeTypeRegistry.h"
+#include "GraphicsContext.h"
+#include "AffineTransform.h"

Should keep these alphabetical.

I believe there is a far-more-efficient way to do tiling with CG, so making
drawTiled a cross-platform function may not be a good direction for the future.


r=me



More information about the webkit-reviews mailing list