[webkit-reviews] review denied: [Bug 12284] Clean up the header guards : [Attachment 12459] go whole-hog

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Jan 15 11:48:22 PST 2007


Rob Buis <rwlbuis at gmail.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 12284: Clean up the header guards
http://bugs.webkit.org/show_bug.cgi?id=12284

Attachment 12459: go whole-hog
http://bugs.webkit.org/attachment.cgi?id=12459&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
IMHO the line between #ifndef and #define should go, as well as the empty line
after that (bad regexp?).

Apart from that you probably want HTMLPARSER_h not too be all uppercase.

Finally it would be neat if #endif could comment the include header too (#endif
// Foo_h)



More information about the webkit-reviews mailing list