[webkit-reviews] review requested: [Bug 12260] Windows platform build is not maintained : [Attachment 12429] Various fixes to make sure the Windows port compiles

[bugzilla-request-daemon at macosforge.org]

Laszlo Gombos <gombi.webkit at gmail.com> has asked  for review:
Bug 12260: Windows platform  build is not maintained
http://bugs.webkit.org/show_bug.cgi?id=12260

Attachment 12429: Various fixes to make sure the Windows port compiles
http://bugs.webkit.org/attachment.cgi?id=12429&action=edit

------- Additional Comments from Laszlo Gombos <gombi.webkit at gmail.com>
Thanks for the review. I made the suggested changes + some additional fixes I
found.

The remaining link errors on Win platform:

webcore.lib(FrameLoader.obj) : error LNK2001: unresolved external symbol
"public: static void __cdecl
WebCore::ResourceHandle::loadResourceSynchronously(struct
WebCore::ResourceRequest const &,class WebCore::ResourceError &,class
WebCore::ResourceResponse &,class WTF::Vector<char,0> &)"
(?loadResourceSynchronously at ResourceHandle@WebCore@@SAXABUResourceRequest at 2@AAV
ResourceError at 2@AAVResourceResponse at 2@AAV?$Vector at D$0A@@WTF@@@Z)
webcore.lib(FrameLoader.obj) : error LNK2001: unresolved external symbol
"public: bool __thiscall
WebCore::DocumentLoader::getResponseModifiedHeader(class WebCore::String
&)const "
(?getResponseModifiedHeader at DocumentLoader@WebCore@@QBE_NAAVString at 2@@Z)
webcore.lib(SubresourceLoader.obj) : error LNK2001: unresolved external symbol
"public: unsigned int __thiscall WebCore::SharedBuffer::size(void)const "
(?size at SharedBuffer@WebCore@@QBEIXZ)
webcore.lib(SubresourceLoader.obj) : error LNK2001: unresolved external symbol
"public: char const * __thiscall WebCore::SharedBuffer::data(void)const "
(?data at SharedBuffer@WebCore@@QBEPBDXZ)
webcore.lib(RenderObject.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::GraphicsContext::clipOut(class
WebCore::IntRect const &)"
(?clipOut at GraphicsContext@WebCore@@QAEXABVIntRect at 2@@Z)
webcore.lib(RenderObject.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::GraphicsContext::fillRoundedRect(class
WebCore::IntRect const &,class WebCore::IntSize const &,class WebCore::IntSize
const &,class WebCore::IntSize const &,class WebCore::IntSize const &,class
WebCore::Color const &)"
(?fillRoundedRect at GraphicsContext@WebCore@@QAEXABVIntRect at 2@ABVIntSize at 2@111ABV
Color at 2@@Z)
webcore.lib(DocumentLoader.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::FrameLoader::didChangeTitle(class
WebCore::DocumentLoader *)"
(?didChangeTitle at FrameLoader@WebCore@@QAEXPAVDocumentLoader at 2@@Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::ResourceHandle::setDefersLoading(bool)"
(?setDefersLoading at ResourceHandle@WebCore@@QAEX_N at Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: static bool __cdecl
WebCore::ResourceHandle::supportsBufferedData(void)"
(?supportsBufferedData at ResourceHandle@WebCore@@SA_NXZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: class WTF::PassRefPtr<class WebCore::SharedBuffer> __thiscall
WebCore::ResourceHandle::bufferedData(void)"
(?bufferedData at ResourceHandle@WebCore@@QAE?AV?$PassRefPtr at VSharedBuffer@WebCore
@@@WTF@@XZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::SharedBuffer::clear(void)"
(?clear at SharedBuffer@WebCore@@QAEXXZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::SharedBuffer::append(char const *,int)"
(?append at SharedBuffer@WebCore@@QAEXPBDH at Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol
"public: __thiscall WebCore::SharedBuffer::SharedBuffer(char const *,int)"
(??0SharedBuffer at WebCore@@QAE at PBDH@Z)
webcore.lib(GraphicsContext.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::GraphicsContext::clipOutEllipseInRect(class
WebCore::IntRect const &)"
(?clipOutEllipseInRect at GraphicsContext@WebCore@@QAEXABVIntRect at 2@@Z)
webcore.lib(ContextMenuController.obj) : error LNK2001: unresolved external
symbol "public: void __thiscall
WebCore::ContextMenu::setPlatformDescription(struct HMENU__ *)"
(?setPlatformDescription at ContextMenu@WebCore@@QAEXPAUHMENU__@@@Z)
webcore.lib(ResourceHandle.obj) : error LNK2001: unresolved external symbol
"public: void __thiscall WebCore::AuthenticationChallenge::nullify(void)"
(?nullify at AuthenticationChallenge@WebCore@@QAEXXZ)
webcore.lib(ResourceHandle.obj) : error LNK2001: unresolved external symbol
"public: __thiscall
WebCore::AuthenticationChallenge::AuthenticationChallenge(void)"
(??0AuthenticationChallenge at WebCore@@QAE at XZ)
G:\WebKitBuild\Release\WebKitWin\WebKit.dll : fatal error LNK1120: 17
unresolved externals