[webkit-reviews] review granted: [Bug 12258] fast/tokenizer/002
test broken : [Attachment 12417] proposed fix
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sun Jan 14 06:11:09 PST 2007
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12258: fast/tokenizer/002 test broken
http://bugs.webkit.org/show_bug.cgi?id=12258
Attachment 12417: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12417&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks great.
I don't like that this calls writeRawData even if len is 0, though. It's also a
bit unfortunate that we need to create a TextResourceDecoder even if there was
no data to decode.
I'm not sure either of those is a problem. I think I'll still say r=me.
More information about the webkit-reviews
mailing list