[webkit-reviews] review denied: [Bug 12214] REGRESSION: css image with relative path is not loaded, when both base element and dir attribute in the html tag are present : [Attachment 12366] This fix updates m_elemSheet's href, whenever document's baseUrl changes.

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12214: REGRESSION: css image with relative path is not loaded, when both
base element and dir attribute in the html tag are present
http://bugs.webkit.org/show_bug.cgi?id=12214

Attachment 12366: This fix updates m_elemSheet's href, whenever document's
baseUrl changes.
http://bugs.webkit.org/attachment.cgi?id=12366&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Great fix!

+    if (m_elemSheet)
+	 m_elemSheet.get()->setHref(m_baseURL);

No need for the ".get()" herre. It can just be m_elemSheet->setHref().

It looks to me like this will not work if the style sheet has an @import rule
in it. The @import rule will load based on the original style sheet href, not
the updated one.

This needs at least one layout test; maybe two because of the @import rule
issue.

I think it's OK to fix this even without a fix for the @import rule issue.

review-, because of the lack of a test