[webkit-reviews] review granted: [Bug 12228] Cleanup assorted CSS
classes : [Attachment 12395] cleanup patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sat Jan 13 07:25:17 PST 2007
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12228: Cleanup assorted CSS classes
http://bugs.webkit.org/show_bug.cgi?id=12228
Attachment 12395: cleanup patch
http://bugs.webkit.org/attachment.cgi?id=12395&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The word "Hand" really shouldn't be capitalized in "shorthand".
Do we really want braces for the for statements that don't need them? I wish
our style guidelines were clear on that.
If anything I'd like to see you applying even more of the m_ prefix. Hyatt was
just talking about how it's hard to work on certain classes because it's so
hard to tell the members apart from local variables.
Fine to land this.
r=me
More information about the webkit-reviews
mailing list