[webkit-reviews] review denied: [Bug 9454] CSS2: Language not inherited from parent element : [Attachment 12390] quick and dirty fix for rob's comments :-)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Jan 12 11:17:50 PST 2007


Rob Buis <rwlbuis at gmail.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 9454: CSS2: Language not inherited from parent element
http://bugs.webkit.org/show_bug.cgi?id=9454

Attachment 12390: quick and dirty fix for rob's comments :-)
http://bugs.webkit.org/attachment.cgi?id=12390&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
>+			  value =
static_cast<Element*>(n)->getAttribute(langAttr);
>+		      // FIXME: Document needs to provide the MIME
content-language
>+		      
>+		      
>+		      
>+		      
>+		      
>+		      n = n->parent();

You don't want the empty lines there.

This patch is much better. However it needs test results included before it can
be okayed.
Cheers,

Rob.



More information about the webkit-reviews mailing list