[webkit-reviews] review granted: [Bug 12190] REGRESSION:
Placeholder text does not reflect dynamic updates :
[Attachment 12363] patch with change log
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Jan 11 09:45:53 PST 2007
Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12190: REGRESSION: Placeholder text does not reflect dynamic updates
http://bugs.webkit.org/show_bug.cgi?id=12190
Attachment 12363: patch with change log
http://bugs.webkit.org/attachment.cgi?id=12363&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+ if (!wasDirty)
+ document()->frame()->textFieldDidBeginEditing(input);
+ document()->frame()->textDidChangeInTextField(input);
Do you need to null-check document() and/or frame() here?
r=me
More information about the webkit-reviews
mailing list