[webkit-reviews] review requested: [Bug 10249] Temporarily disable tests that are causing kernel panics : [Attachment 12360] Make ImageDiff not use CoreImage

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Jan 11 07:33:24 PST 2007


mitz at webkit.org has asked  for review:
Bug 10249: Temporarily disable tests that are causing kernel panics
http://bugs.webkit.org/show_bug.cgi?id=10249

Attachment 12360: Make ImageDiff not use CoreImage
http://bugs.webkit.org/attachment.cgi?id=12360&action=edit

------- Additional Comments from mitz at webkit.org
This patch makes ImageDiff not cause kernel panics on at least one machine
where it used to (2GHz MacBook Pro).

The results difference images produced with this patch are equivalent but not
identical to current ones: the CoreImage version amplified small differences.
However the percentage of different pixels reported should be the same, and any
difference, as small as one unit in on component, show in the difference image.



More information about the webkit-reviews mailing list