[webkit-reviews] review granted: [Bug 12201] Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg : [Attachment 12356] Improved patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Jan 11 01:01:15 PST 2007


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12201: Fix image dragging issues with
http://www.carto.net/papers/svg/gui/scrollbar/index.svg
http://bugs.webkit.org/show_bug.cgi?id=12201

Attachment 12356: Improved patch
http://bugs.webkit.org/attachment.cgi?id=12356&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This looks good.

Please add a comment about viewportTransform() not including translation.  As
you mentioned on IRC, this is confusing due to <svg> and <g> both using
RenderSVGContainer (and one of them having only localTransform and one having
only viewportTransform())

I filed:
http://bugs.webkit.org/show_bug.cgi?id=12207
about splitting them up.



More information about the webkit-reviews mailing list