[webkit-reviews] review denied: [Bug 12201] Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg : [Attachment 12349] First attempt

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12201: Fix image dragging issues with
http://www.carto.net/papers/svg/gui/scrollbar/index.svg
http://bugs.webkit.org/show_bug.cgi?id=12201

Attachment 12349: First  attempt
http://bugs.webkit.org/attachment.cgi?id=12349&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Glad to see this one fixed!

Bleh.  temp and ret are really bad variable names.  We should use something
more descriptive.

This extra multiply is not necessary:
-	 return getAspectRatio(viewBox(), viewportRect);
+	 ret = getAspectRatio(viewBox(), viewportRect) * ret;

ret should be the identity there.

I'm not 100% sure this is correct.  It probably is, but I'd like to you tell me
more about it over IRC.