[webkit-reviews] review granted: [Bug 12145] Color parsing is too relaxed in strict mode : [Attachment 12336] First attempt

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12145: Color parsing is too relaxed in strict mode
http://bugs.webkit.org/show_bug.cgi?id=12145

Attachment 12336: First attempt
http://bugs.webkit.org/attachment.cgi?id=12336&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, r=me.

+    if (Color::parseHexColor(name, rgb) && !strict)
	 return true;

It would be nice to not even parse in the strict case. Just reverse the two
halves of the &&.

+	 static RGBA32 parseColor(const String&, bool = false);

Should have the name strict here, since bool along doesn't make it clear what
the parameter is.

+	 static bool parseColor(const String&, RGBA32& rgb, bool);

Ditto.