[webkit-reviews] review requested: [Bug 12170] RenderView holds dangling reference to RenderObjects as selection markers : [Attachment 12320] proposed patch

[bugzilla-request-daemon at macosforge.org]

Dex Deacon <occupant4 at gmail.com> has asked  for review:
Bug 12170: RenderView holds dangling reference to RenderObjects as selection
markers
http://bugs.webkit.org/show_bug.cgi?id=12170

Attachment 12320: proposed patch
http://bugs.webkit.org/attachment.cgi?id=12320&action=edit

------- Additional Comments from Dex Deacon <occupant4 at gmail.com>
enums are signed on Windows, so in this case, m_selectionState = 4 results in
m_selectionState == -4.  This was causing a RenderText object not to be
recognized as selected, so it was deleted without clearing the selection,
resulting in a dangling ref to it.

I was wrong that this applied to Mac as well.  It appears Mac treats enums as
unsigned in this case.	My asserts were firing for other reasons.