[webkit-reviews] review granted: [Bug 12158] Implement CSS3 multi column support : [Attachment 12296] Revised patch addressing Eric and MItz's review comments.

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12158: Implement CSS3 multi column support
http://bugs.webkit.org/show_bug.cgi?id=12158

Attachment 12296: Revised patch addressing Eric and MItz's review comments.
http://bugs.webkit.org/attachment.cgi?id=12296&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
My thoughts:

1.  You'll need lots more tests... eventually.
2.  ideally the z-index thing would be separate, but it's OK as is.
3.  Some of this new code (including the z-index stuff) could really be a macro
to avoid more copy/paste trouble.  But it's OK as is.

Looks good.