[webkit-reviews] review denied: [Bug 9284] Quirksmode (CSS1): Removing inline border styles is impossible : [Attachment 12285] Expand shorthands for removal

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9284: Quirksmode (CSS1): Removing inline border styles is impossible
http://bugs.webkit.org/show_bug.cgi?id=9284

Attachment 12285: Expand shorthands for removal
http://bugs.webkit.org/attachment.cgi?id=12285&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> Hiding here (I wanted to reuse the first 4 arrays):

> +    shorthandMap->set(CSS_PROP_BORDER, new
PropertyLonghand(borderTopProperties, (sizeof(borderTopProperties) +
sizeof(borderRightProperties) + sizeof(borderBottomProperties) > +
sizeof(borderLeftProperties)) / sizeof(borderTopProperties[0])));

That technique is not reliable. It relies on the four arrays being consecutive
in global data, something that is not guaranteed by the C++ language.