[webkit-reviews] review granted: [Bug 11917] setlocale() can return null : [Attachment 12292] Patch v2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Jan 7 21:21:53 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11917: setlocale() can return null
http://bugs.webkit.org/show_bug.cgi?id=11917

Attachment 12292: Patch v2
http://bugs.webkit.org/attachment.cgi?id=12292&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me; clearly the best short term solution to this problem

On the other hand, the code probably meant to set the locale to "" or "C" or
"POSIX" -- maybe some day we'll find ourselves adding code to do that. We'll
need to test date-related tests on platforms other than Mac OS X with the
current locale set to exotic ones to find out if that is needed.



More information about the webkit-reviews mailing list