[webkit-reviews] review requested: [Bug 7640] Menu items are displayed as "undefined" : [Attachment 12277] proposed fix

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 7640: Menu items are displayed as "undefined"
http://bugs.webkit.org/show_bug.cgi?id=7640

Attachment 12277: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12277&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The problem here was that a local variable "item" got shadowed by Node::item
within a "with" block. AFAICT, there is no reason to have this method on Node.
"Gecko DOM reference" cited in code comment is probably
<http://developer.mozilla.org/en/docs/DOM:element.item>, which specifically
states that "despite this article's name, item() is not a method of DOM Element
or Node."

The included test passes in Firefox 2 and IE 6.