[webkit-reviews] review requested: [Bug 12124] RenderTable::section{Above, Below}() can return the wrong answer for the {footer, header} : [Attachment 12273] Patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Jan 7 00:49:37 PST 2007


mitz at webkit.org has asked  for review:
Bug 12124: RenderTable::section{Above,Below}() can return the wrong answer for
the {footer,header}
http://bugs.webkit.org/show_bug.cgi?id=12124

Attachment 12273: Patch
http://bugs.webkit.org/attachment.cgi?id=12273&action=edit

------- Additional Comments from mitz at webkit.org
(In reply to comment #2)
> (From update of attachment 12257 [edit])
> I think resetSectionPointerIfNotBefore needs an assertion that o is a table
> section as the caption code does that o is a RenderBlock; in fact, I'm not at

> all sure that there's a guarantee that o is a RenderBlock.

The assignments of o (to ptr and to m_caption) where either no-ops or 0
assignments. I changed things to not do the no-op and to make the 0 assignment
explicit, so no cast is needed.



More information about the webkit-reviews mailing list