[webkit-reviews] review requested: [Bug 10725] Image data in from RTFD clipboard data thrown away : [Attachment 12253] patch 10 (code only)

[bugzilla-request-daemon at macosforge.org]

Graham Dennis <Graham.Dennis at gmail.com> has asked Maciej Stachowiak
<mjs at apple.com> for review:
Bug 10725: Image data in from RTFD clipboard data thrown away
http://bugs.webkit.org/show_bug.cgi?id=10725

Attachment 12253: patch 10 (code only)
http://bugs.webkit.org/attachment.cgi?id=12253&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Patch 10 (code only, the layout test is the same)

Updated to ToT.
The only reason the WebDataProtocol change is necessary is because Safari will
crash trying to set an object for a nil key in a dictionary. This seems to be
related to the activity viewer. That said, I did some testing to see if
anything else broke as a result of this change. I tried opening the 'view
source' window on a number of different pages in Safari, and that worked fine
(is this just what you wanted checked, or was it something more specific). I
tried using the snippet editor, except that it doesn't appear to work in ToT
(and still doesn't work with 10725). I also tried entering
'applewebdata://<stuff>' URL's into Safari to see if a load error page would
come up, except that Safari just said 'contacting server' in both ToT and with
10725. I also tried 'random://<stuff>' but that also didn't display a load
error page (both applewebdata:// and random:// show load error pages in
released Safari.).