[webkit-reviews] review requested: [Bug 10362] SVG needs to support SVGError events and some form of "error state" : [Attachment 12244] Improved patch

[bugzilla-request-daemon at macosforge.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 10362: SVG needs to support SVGError events and some form of "error state"
http://bugs.webkit.org/show_bug.cgi?id=10362

Attachment 12244: Improved patch
http://bugs.webkit.org/attachment.cgi?id=12244&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This should fix most of MacDome's issues. It doesnt seem worth it to make
lineNumber() pure virtual, since three Tokenizer-derived classes in loader/
would need the same base implementation.
It is hard to get the js line numbers. Maybe that needs to be done later.
I also split out Tokenizer itself. That is not really required for this patch
to work, but I thought it may make sense.
Cheers,

Rob.