[webkit-reviews] review denied: [Bug 10362] SVG needs to support SVGError events and some form of "error state" : [Attachment 12193] Improved patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Jan 5 00:56:12 PST 2007


Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10362: SVG needs to support SVGError events and some form of "error state"
http://bugs.webkit.org/show_bug.cgi?id=10362

Attachment 12193: Improved patch
http://bugs.webkit.org/attachment.cgi?id=12193&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
we discussed a bunch of improvements over irc, including making lineNumber(),
etc pure virtual, using contextElement() instead of passing document() and
cleaning up the long ifs which repeatedly called the same error message.



More information about the webkit-reviews mailing list