[webkit-reviews] review granted: [Bug 7296] JavaScript error not thrown when trying to set a CSS property to an invalid value : [Attachment 12010] without a Dashboard quirk

[bugzilla-request-daemon at macosforge.org]

Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 7296: JavaScript error not thrown when trying to set a CSS property to an
invalid value
http://bugs.webkit.org/show_bug.cgi?id=7296

Attachment 12010: without a Dashboard quirk
http://bugs.webkit.org/attachment.cgi?id=12010&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I'm going to approve this patch.

ap mentioned on IRC that neither IE nor Firefox deletes the property when it
fails to parse, so I think this is a compatibilty improvement. Let's not add a
Dashboard quirk until it proves necessary.

Please remember to do these things before landing:
- Remove mention of the quirk from the ChangeLog
- Change to ASSERT(!ec), to match our style guidelines
- Add a test the verifies that a syntax error does not remove the previous
property (i don't think that was covered by the original patch)