[webkit-reviews] review requested: [Bug 12106] Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored : [Attachment 12233] patch 1

[bugzilla-request-daemon at macosforge.org]

Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 12106: Changed URL from WebResourceLoadDelegate's
webView:resource:willSendRequest:... is ignored
http://bugs.webkit.org/show_bug.cgi?id=12106

Attachment 12233: patch 1
http://bugs.webkit.org/attachment.cgi?id=12233&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Patch 1.
Passes layout tests, but no layout test added, as to test this, you need to be
able to create a WebResourceLoadDelegate.

The problem was that m_request isn't set until the end of
ResourceLoader::willSendRequest(), and so oldURL was always empty. But even if
we replace oldURL with m_originalURL (which is set at the start of
ResourceLoader::load()), the newRequest is only updated if the new and old URLs
are the same. This patch fixes both problems so that WebResourceLoadDelegates
can now change URLs.