[webkit-reviews] review denied: [Bug 12078] Clean up RenderTable* : [Attachment 12213] RenderTable* cleanup and reorg

[bugzilla-request-daemon at macosforge.org]

Sam Weinig <sam at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 12078: Clean up RenderTable*
http://bugs.webkit.org/show_bug.cgi?id=12078

Attachment 12213: RenderTable* cleanup and reorg
http://bugs.webkit.org/attachment.cgi?id=12213&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
A couple more nits

In FixedTableLayout.cpp:

put spaces around the infix '+'

m_width[cCol+i].setRawValue(w.type(), w.rawValue() * eSpan);

and here

if (m_width[cCol+i].isAuto() && w.type() != Auto) {
    m_width[cCol+i].setRawValue(w.type(), w.rawValue() * eSpan);

and here around the infix '-'

+    m_table->columnPositions()[m_table->columnPositions().size()-1] = pos;


In RenderTableSection.cpp:

Convert to use max()

if (totalPercent > 100 * percentScaleFactor)
    totalPercent = 100 * percentScaleFactor;