[webkit-reviews] review requested: [Bug 12070] REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes : [Attachment 12205] Patch v1

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Jan 3 22:01:52 PST 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 12070: REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time
zone changes
http://bugs.webkit.org/show_bug.cgi?id=12070

Attachment 12205: Patch v1
http://bugs.webkit.org/attachment.cgi?id=12205&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
If the user changes time zones without restarting a WebKit application like
Safari, the cached UTC offset will cause JavaScript to report the wrong time
zone and/or the wrong time.  The simple solution is to stop caching the UTC
offset and calculate it every time.  That's what this patch does.

Note that no performance testing has been done.



More information about the webkit-reviews mailing list