[webkit-reviews] review denied: [Bug 11611] REGRESSION: No http referer header sent on XMLHttpRequest : [Attachment 12185] proposed fix

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11611: REGRESSION: No http referer header sent on XMLHttpRequest
http://bugs.webkit.org/show_bug.cgi?id=11611

Attachment 12185: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12185&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    NSMutableURLRequest *newNSURLRequest = [newRequest.nsURLRequest()
mutableCopy];
+
+    // FIXME: should this be in ResourceRequest::nsURLRequest()?
+    wkSupportsMultipartXMixedReplace(newNSURLRequest);
 
     RefPtr<SubresourceLoader> subloader(new SubresourceLoader(frame, client));

     if (!subloader->load(newNSURLRequest))
	 return 0;
 
-    [newNSURLRequest release];
-

Looks like a storage leak here. newNSURLRequest is a copy and needs to be
released.

Otherwise looks quite good!