[webkit-reviews] review requested: [Bug 5164] Non-integer percentages are incorrectly rounded down in Safari : [Attachment 12157] Increase percent precision; no change log or layout tests

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Jan 2 01:43:41 PST 2007


mitz at webkit.org has asked  for review:
Bug 5164: Non-integer percentages are incorrectly rounded down in Safari
http://bugs.webkit.org/show_bug.cgi?id=5164

Attachment 12157: Increase percent precision; no change log or layout tests
http://bugs.webkit.org/attachment.cgi?id=12157&action=edit

------- Additional Comments from mitz at webkit.org
I'm not sure about any of the changes to Length.h, i.e. the Length interfaces,
but they allowed me to map out all uses of Length and make them "scaled
percent"-safe. So basically after the final Length interfaces are decided, it
should be easy to go back to all these places and adapt them if necessary.

Affected layout tests (previous figure of 5 was for scaling by 10, with 128
there's two more):
css1/box_properties/acid_test
css2.1/t09-c5526c-display-00-e
css2.1/t0804-c5507-padn-r-00-c-ag
css2.1/t0804-c5509-padn-l-00-b-ag
fast/block/basic/011
tables/mozilla/bugs/bug4385
tables/mozilla_expected_failures/core/col_span2

All seem like progressions.



More information about the webkit-reviews mailing list