[webkit-reviews] review granted: [Bug 11849] REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly) : [Attachment 12144] Change pcre_compile to take the pattern's length and work with patterns containing null characters

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11849: REGRESSION (r18182): Google Calendar is broken (a regular expression
containing a null character is not parsed correctly)
http://bugs.webkit.org/show_bug.cgi?id=11849

Attachment 12144: Change pcre_compile to take the pattern's length and work
with patterns containing null characters
http://bugs.webkit.org/attachment.cgi?id=12144&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
       /* The space before the ; is to avoid a warning on a silly compiler
       on the Macintosh. */

The above comment no longer makes sense.

This is by far the biggest change we've ever made to PCRE! But it's worth it.

Merging with future versions of PCRE is going to be rather difficult.

r=me