[webkit-reviews] review requested: [Bug 8438] iExploder(#460): Assertion failure in RenderObject::drawBorder() : [Attachment 12142] Patch

[bugzilla-request-daemon at macosforge.org]

mitz at webkit.org has asked  for review:
Bug 8438: iExploder(#460): Assertion failure in RenderObject::drawBorder()
http://bugs.webkit.org/show_bug.cgi?id=8438

Attachment 12142: Patch
http://bugs.webkit.org/attachment.cgi?id=12142&action=edit

------- Additional Comments from mitz at webkit.org
The only good thing I can say about this patch is that it probably works.

calcMinMaxWidth needs to be patched. I could have copied and thinned down
RenderBlock's implementation instead of tail-patching it. Not sure which way is
better.

Then there is actual width calculation. This patch pretends that there's a CSS
min-width protecting the legend. It takes care of the normal, inline and
positioned cases. I looked into alternative approaches but all seemed to
require turning more methods into virtual methods and/or copying large amount
of code from RenderBox to RenderFieldset.

Any thoughts?