[webkit-reviews] review denied: [Bug 12931] ARM crash due to
non-aligned memory access : [Attachment 13431] ARM crash due
to non-aligned memory access
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Feb 28 17:20:35 PST 2007
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12931: ARM crash due to non-aligned memory access
http://bugs.webkit.org/show_bug.cgi?id=12931
Attachment 13431: ARM crash due to non-aligned memory access
http://bugs.webkit.org/attachment.cgi?id=13431&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This will break the build on Mac OS X, because we will get a warning (treated
as an error) about the aligned4 function unused but having internal linkage.
Is it really worthwhile to optimize the aligned case? Instead we should
probably just always use the character loop on ARM and ignore the faster loop
entirely.
More information about the webkit-reviews
mailing list