[webkit-reviews] review denied: [Bug 12821] Number.toExponential doesn't work for negative numbers : [Attachment 13340] Fixes mathematical error in Number, with LayoutTest

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Feb 27 23:00:26 PST 2007


Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12821: Number.toExponential doesn't work for negative numbers
http://bugs.webkit.org/show_bug.cgi?id=12821

Attachment 13340: Fixes mathematical error in Number, with LayoutTest
http://bugs.webkit.org/attachment.cgi?id=13340&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Moving to r- based on Alexey's comments - we don't want to check in a new test
in a way that fails right out of the gate. That does not do a very good job of
showing the fix. Better would be something that fails before and passes after.



More information about the webkit-reviews mailing list