[webkit-reviews] review requested: [Bug 12720] Re-defining window.location.toString function keeps re-loading forever : [Attachment 13417] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Feb 27 18:41:03 PST 2007


Ian Eng <ian.eng.webkit at gmail.com> has asked Maciej Stachowiak <mjs at apple.com>
for review:
Bug 12720: Re-defining window.location.toString function keeps re-loading
forever
http://bugs.webkit.org/show_bug.cgi?id=12720

Attachment 13417: patch
http://bugs.webkit.org/attachment.cgi?id=13417&action=edit

------- Additional Comments from Ian Eng <ian.eng.webkit at gmail.com>
The bug is caused by Location::put if the property name is a function name in
the LocationTable. It does not change URL, but put() will think the URL was
changed and reload the file again, and into an infinite loop. The fix just
returns early when it founds the property name is in the LocationTable, but not
changing URL.



More information about the webkit-reviews mailing list