[webkit-reviews] review denied: [Bug 12901] [S60] Browser ask permission for unsecure item load repeatedly : [Attachment 13399] TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

[bugzilla-request-daemon at macosforge.org]

Yongjun Zhang <yongjun.zhang at nokia.com> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 12901: [S60] Browser ask permission for unsecure item load repeatedly
http://bugs.webkit.org/show_bug.cgi?id=12901

Attachment 13399: TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure
item load repeatedly
http://bugs.webkit.org/attachment.cgi?id=13399&action=edit

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
I think the patch is incorrect:
1. maintaining iNonSecureItemShown in both CWebKitLoader and CHttpLoader is
redundant.
2. add global flags in WebKitLoader for this purpose is generally not a good
idea.
3. In CHttpLoader::CheckSecurityStatus, the patch only considered one senario
when a secure page requests insecure subresources.  How about a insure page
requests multiple secure sburesources. The ESecureItemInNonSecurePage	dialog
will show up multiple times.

the patch is rejected based on abovementioned reasons.